-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a few navigation shortcuts #61
Conversation
Cool. At a glance I feel like this fits in well. I'll take a closer look soon.
Let me give that a bit amount of thought. The evolving "bevy development roadmap landscape" may have changed my thoughts a bit. |
As implemented here, there's an issue where if e.g. But more generally, it's not possible to know which key arrived first unless we deal with a single stream of events. This sort of bug was my bane from Bevy versions 0.4 -> 0.13 when it finally became possible to fix it properly. So I would strongly prefer to do our processing on a single event stream. I think that a way around this might be to roughly:
I am open to other ideas but I think that would even simplify things overall. |
I guess having a primary button for the action would avoid moving twice if you hold right and press the modifier twice too. Ok let me try. |
i added modifiers and moved the char left/right and backspace+delete into the enum. i can make a separate system if you like, but i'm not sure the benefit is that much (and cloning the reader is super-cheap, it's just a usize) |
Looks great, thanks! |
adds support for (configurable) word left/right and line start/end navigation.
i'm in the process of removing egui from my app, and text entry is the main blocker. to that end i hope to also add support for
i fully understand if you think this pr and these other features are out of scope of a "simple" text entry field though.